Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: Pass options to websocket server #66

Merged
merged 1 commit into from
Apr 5, 2018
Merged

feat: Pass options to websocket server #66

merged 1 commit into from
Apr 5, 2018

Conversation

mkg20001
Copy link
Member

No description provided.

@ghost ghost assigned mkg20001 Oct 30, 2017
@ghost ghost added the status/in-progress In progress label Oct 30, 2017
dignifiedquire
dignifiedquire suggested changes Nov 7, 2017
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test, to make sure this doesn't break again?

@mkg20001
Copy link
Member Author

I can't as the variable is never exposed anywhere.
Btw here is the only part where it gets used: https://github.com/pull-stream/pull-ws/blob/master/server.js#L31-L32

@daviddias daviddias merged commit 709989a into master Apr 5, 2018
@daviddias daviddias deleted the pass-options branch April 5, 2018 16:21
@ghost ghost removed the status/in-progress In progress label Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dignifiedquire dignifiedquire dignifiedquire requested changes

@daviddias daviddias daviddias approved these changes

Assignees

@mkg20001 mkg20001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkg20001 @dignifiedquire @daviddias