This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat: skip p2p-circuit addresses #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
daviddias
suggested changes
Jul 24, 2017
| if (includes(ma.protoNames(), 'ipfs')) { | ||
| if (includes(ma.protoNames(), 'p2p-circuit')) { | ||
| return false | ||
| } else if (includes(ma.protoNames(), 'ipfs')) { |
There was a problem hiding this comment.
I do, but decapsulated will strip the ipfs part along with p2p-circuit, so mafmt wont match it. Mafmt does have all the logic to do the matches correctly tho.
|
not needed anymore, going to be handled by mafmt |
|
@diasdavid can we get this reopened, as per our discussion earlier today? 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore
/p2p-circuitaddresses