This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix deps #254
Merged
fix deps #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced May 9, 2018
|
These PRs are only needed to ensure CI runs correctly with the new implementation. It is not supposed to get merged just yet, it need pull-mplex and libp2p-mplex published first. Please don't change them. |
daviddias
force-pushed
the
feat/pull-mplex
branch
from
4611c59 to
e14e709
Compare
daviddias
reviewed
May 12, 2018
| @@ -10,7 +10,7 @@ const each = require('async/each') | |||
| const map = require('async/map') | |||
| const series = require('async/series') | |||
| const TCP = require('libp2p-tcp') | |||
| const multiplex = require('libp2p-multiplex') | |||
| const multiplex = require('libp2p-mplex') | |||
There was a problem hiding this comment.
@dryajov this was a legit issue that fixes it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Im using libp2p-mplex as a git dep, so that we can test it on CI. This is temporary and should be changed once libp2p-mplex is released.