Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

feat: sort available transports by priority #217

Closed
wants to merge 2 commits into from

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Apr 3, 2017

This uses the the priority property added in the bellow PRs to prioritize order of transport dialing.

libp2p/js-libp2p-tcp#78 (see this for discussion)
libp2p/js-libp2p-websockets#61

If we decide to go with this, we'd need to add priority to the remaining transports as well.

@daviddias daviddias mentioned this pull request Apr 13, 2017
53 tasks
@dryajov dryajov changed the title [Poroposal] feat: sort available transports by priority feat: sort available transports by priority Apr 16, 2017
@dryajov
Copy link
Member Author

dryajov commented Apr 16, 2017

After this commit (0423744), we no longer need the related changes in each transport.

@daviddias
Copy link
Member

Hi @dryajov. This sounds like a good idea in the long term but priorities essentially mean nothing until we expose these features to the user to configure. Setting default priorities is exactly the same as prioritizing direct connections and putting on second plan the relayed ones, which makes sense to do.

Let's avoid yet adding one more piece to the interface-transport abstraction until we actually need it. The sort function is: direct connections first, relayed second.

@dryajov
Copy link
Member Author

dryajov commented May 10, 2017

@diasdavid I'll remove the priority in favor of pushing circuit addresses to be dialed last.

@daviddias daviddias closed this May 12, 2017
@daviddias daviddias deleted the feat/sort-transports branch May 12, 2017 22:18
@dryajov dryajov mentioned this pull request Aug 16, 2017
48 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants