This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat!: change connection interface to use Uint8ArrayList #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a coverage file crept into this PR? |
true, I also need to update it-handshake |
|
should this change also be applied to muxed streams? |
|
closing in favour of #278 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@achingbrain it seems like it-handshake is used to exchange peer id.
I hacked to not use it-handshake transform after that as it converts everything to Uint8Array.
I will try to open PR to it-handshake without breaking change