This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
chore: add discourse badge #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
reviewed
Apr 22, 2019
| - npm install -g npm | ||
|
|
||
| script: | ||
| - npm run lint |
There was a problem hiding this comment.
We should include the new travis file with at least linting included. It will also be needed if we add tests for the new async update
jacobheun
reviewed
Apr 22, 2019
| [](http://libp2p.io/) | ||
| [](http://webchat.freenode.net/?channels=%23libp2p) | ||
| [](https://discuss.libp2p.io) | ||
| [](https://codecov.io/gh/libp2p/interface-connection) |
There was a problem hiding this comment.
Codecov won't return anything until we add tests as a part of #29. We can probable leave this in since that should be done soon.
vasco-santos
force-pushed
the
chore/add-discourse-badge
branch
from
b46caf9 to
5298015
Compare
jacobheun
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of libp2p/libp2p#74, the badge for discuss.libp2p.io was added.
Dependencies were also updated and
travisCI old config was removed. Once a suite of tests is added, the new config will be added