Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Update Travis CI to use standard test script. #21

Closed
wants to merge 5 commits into from

Conversation

kevina
Copy link

@kevina kevina commented Nov 17, 2017

No description provided.

@ghost ghost assigned kevina Nov 17, 2017
@ghost ghost added the in progress label Nov 17, 2017
@kevina
Copy link
Author

kevina commented Nov 17, 2017

Is there still a need to test with go 1.6?

@kevina
Copy link
Author

kevina commented Nov 17, 2017

Nevermind I am assuming that is outdated code.

New question: Is there a reason to still use tip which is the latest devel version and not just go 1.9?

@Stebalien
Copy link
Member

New question: Is there a reason to still use tip which is the latest devel version and not just go 1.9?

It allows us to catch upstream bugs/changes early. We don't do it all over the place but this package runs all of our smux tests.

@kevina
Copy link
Author

kevina commented Nov 17, 2017

It allows us to catch upstream bugs/changes early. We don't do it all over the place but this package runs all of our smux tests.

Okay I will use both tip and 1.9.x then.

@kevina
Copy link
Author

kevina commented Nov 17, 2017

Note suit_test.go is failing and not sure the best way to fix it...

@Stebalien
Copy link
Member

@kevina I'm looking into that.

@Stebalien
Copy link
Member

Fixing this by removing the tests. Continuing in #24.

@bigs bigs closed this Sep 4, 2018
@ghost ghost removed the in progress label Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants