When a stream is closed, cancel pending writes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested changes
Dec 14, 2018
There was a problem hiding this comment.
Thanks!
How about storing a context and a cancel function in the stream itself? write can then just pass this context through (attaching the deadline if necessary) and we can avoid the double close issue (it's safe to call cancel twice) and the additional goroutine.
Ichbinjoe
force-pushed
the
feat/cancel-write
branch
from
4b1acc2 to
37a0fde
Compare
Ichbinjoe
force-pushed
the
feat/cancel-write
branch
from
37a0fde to
f0d2c32
Compare
|
I'm not sure why I had chosen this method over just storing the context, but considering I can't think of the reason a day later, it must not have been a very good reason. |
Stebalien
approved these changes
Dec 15, 2018
|
LGTM but someone from the libp2p team should really get the final signoff. @bigs? |
|
Thanks @vyzo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be relatively straight forward. #9