Connection Gating in a libp2p node #877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Apr 7, 2020
| @@ -4,7 +4,6 @@ import ( | |||
| "context" | |||
| "crypto/rand" | |||
| "fmt" | |||
|
|
|||
There was a problem hiding this comment.
the import block separation is desirable, i think
| "github.com/libp2p/go-libp2p-core/connmgr" | ||
| "github.com/libp2p/go-libp2p-core/crypto" | ||
| "github.com/libp2p/go-libp2p-core/metrics" | ||
| "github.com/libp2p/go-libp2p-core/network" | ||
| "github.com/libp2p/go-libp2p-core/peer" | ||
| "github.com/libp2p/go-libp2p-core/peerstore" | ||
| "github.com/libp2p/go-libp2p-core/pnet" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
you don't need this dep. either the system built-in "errors" can be used for errors.New, or you can use the already included fmt for fmt.Errorf().
| // ConnectionGater configures libp2p to use the given Connection Gater | ||
| // to reject incoming/outgoing connections based om the logic implemented in the gater. | ||
| // Note: This Option has replaced the earlier "Filters" AND "FilterAddresses" Options. | ||
| // Please use "filter.ToConnectionGater" to configure this of you already have an instance of a "go-maddr-filter.Filter". |
There was a problem hiding this comment.
Suggested change
| // Please use "filter.ToConnectionGater" to configure this of you already have an instance of a "go-maddr-filter.Filter". | |
| // Existing users of go-maddr-filter.Filter may use "filter.ToConnectionGater" for compatibility. |
|
Closing in favour of #881 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #872 .
Core PR at libp2p/go-libp2p-core#139.
Swarm PR at libp2p/go-libp2p-swarm#201.
Transport Upgrader PR at libp2p/go-libp2p-transport-upgrader#55.
MultiAddr Filter PR at libp2p/go-maddr-filter#21.