Signal address change #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Mar 24, 2020
p2p/host/basic/basic_host.go
Outdated
| go func() { | ||
| for { | ||
| select { | ||
| case <-h.addrChangeChan: |
There was a problem hiding this comment.
can you not incorporate this into the below for() loop on the background goroutine, rather than adding the additional event loop for translating this event?
There was a problem hiding this comment.
Good idea, have made the change.
willscott
approved these changes
Mar 24, 2020
p2p/host/basic/basic_host.go
Outdated
| case <-p.Closing(): | ||
| return | ||
| } | ||
|
|
||
| // emit an EvtLocalAddressesUpdatedEvent & a Push Identify if our listen addresses have changed. | ||
| h.mx.Lock() |
There was a problem hiding this comment.
mutex can be removed fully now that it's replaced with a channel.
Stebalien
approved these changes
Mar 24, 2020
| if !ok { | ||
| return false | ||
| if changeEvt != nil { | ||
| err := h.emitters.evtLocalAddrsUpdated.Emit(*changeEvt) |
There was a problem hiding this comment.
nit: we don't even need to store this emitter in the host, we can just create it and close it within this loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien
For #848.