fix multiple issues in the mock tests #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we can try to remove it before we add it and panic.
fixes psmem.Close()
willscott
approved these changes
Mar 23, 2020
willscott
reviewed
Mar 23, 2020
| _, err := FullMeshConnected(context.Background(), 2) | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| _, err := FullMeshConnected(ctx, 2) | ||
| cancel() |
There was a problem hiding this comment.
the need for this seems to indicate there are still tasks attached to the context by this process that aren't cleaned up as we might hope. canceling the context solves this problem and is good to be able to do, but we should probably mark the underlying laziness for cleanup as well.
There was a problem hiding this comment.
FullMessConnected returns a fully connected network. Unfortunately, the "correct" way to close that network is to cancel the context. There's no explicit close function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were OOMing on my machine and I ended up digging through multiple bugs.