Added missing error check in test #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since err gets assigned, I assume we also want to check for it being nil.
raulk
approved these changes
Jul 22, 2019
t4n6a1ka
pushed a commit
to t4n6a1ka/go-libp2p
that referenced
this pull request
Sep 5, 2019
t4n6a1ka
pushed a commit
to t4n6a1ka/go-libp2p
that referenced
this pull request
Sep 5, 2019
t4n6a1ka
added a commit
to t4n6a1ka/go-libp2p
that referenced
this pull request
Sep 5, 2019
* TestStreamsStress: reduce node count, increase stream density. * upgrade peerstore. * fix libp2p#672: wait until done; fix ponger response. * remove superfluous goroutine; avoid t.Fatal from goroutines. * mdns: always use interface addresses We don't want to use the transformed/munged host addresses for local announcements. Ideally, we'd take a more scientific approach to this (i.e., "host, please give me addresses relative to X") but we can't do that yet. * Removed ineffectual assignments We don't use `cs` here, drop it. * Fixed typos (libp2p#680) Just a few nit-picky typo fixes. * Make use of time.Until & time.Since (libp2p#681) No need to manually subtract timestamps. * Simplify increments (libp2p#684) * Avoid unnecessary conversions (libp2p#685) No need to convert these types. * Added missing error check in test (libp2p#683) * gomod: update go-libp2p-circuit * autorelay: ensure candidate relays can hop * Update deps, mocknet tests * Adjust test timings for Ed25519 * Bump secio * Bump swarm version * new: allow overriding the user-agent with an option Instead of using a global variable. This also: * Adds an option to the identify service to set the user agent. * Removes the ability to pass an identify service to NewHost as any reasonable Identify service already needs to be constructed with an instance of the host. * set a default client-version using go modules This should help us improve network stats on who's using libp2p. * ci: bump go to 1.12 * README: bump to go 1.12 * dep: update go-libp2p-swarm Fixes a race condition when a user modifies the address list returned by InterfaceListenAddresses. * use new constructor for insecure transport (libp2p#706) * dep: upgrade eventbus to v0.1.0 (libp2p#709) * add godocs. * Update main.yml * Add Filters option (libp2p#717) The new `Filters` option allows users to take ownership of the `Filters` struct, and is suitable for cases where the addresses you want to accept/deny change dynamically. * Rename main.yml to : [^main.yml] * mdns: always use interface addresses We don't want to use the transformed/munged host addresses for local announcements. Ideally, we'd take a more scientific approach to this (i.e., "host, please give me addresses relative to X") but we can't do that yet. * TestStreamsStress: reduce node count, increase stream density. * upgrade peerstore. * fix libp2p#672: wait until done; fix ponger response. * remove superfluous goroutine; avoid t.Fatal from goroutines. * Removed ineffectual assignments We don't use `cs` here, drop it. * Fixed typos (libp2p#680) Just a few nit-picky typo fixes. * Make use of time.Until & time.Since (libp2p#681) No need to manually subtract timestamps. * Simplify increments (libp2p#684) * Avoid unnecessary conversions (libp2p#685) No need to convert these types. * Added missing error check in test (libp2p#683) * gomod: update go-libp2p-circuit * autorelay: ensure candidate relays can hop * Update deps, mocknet tests * Adjust test timings for Ed25519 * Bump secio * Bump swarm version * new: allow overriding the user-agent with an option Instead of using a global variable. This also: * Adds an option to the identify service to set the user agent. * Removes the ability to pass an identify service to NewHost as any reasonable Identify service already needs to be constructed with an instance of the host. * set a default client-version using go modules This should help us improve network stats on who's using libp2p. * ci: bump go to 1.12 * README: bump to go 1.12 * dep: update go-libp2p-swarm Fixes a race condition when a user modifies the address list returned by InterfaceListenAddresses. * use new constructor for insecure transport (libp2p#706) * dep: upgrade eventbus to v0.1.0 (libp2p#709) * add godocs. * Add Filters option (libp2p#717) The new `Filters` option allows users to take ownership of the `Filters` struct, and is suitable for cases where the addresses you want to accept/deny change dynamically. * Rename : [^main.yml] to `.'yml*go (sawi) * Rename `.'yml*go (sawi) to `.'yml*go #(sawi) * Rename `.'yml*go #(sawi) to `.'yml*go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since err gets assigned, I assume we also want to check for it being nil.