Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the goprocess for closing #669

Merged
merged 7 commits into from
Jul 4, 2019
Merged

fix: use the goprocess for closing #669

merged 7 commits into from
Jul 4, 2019

Conversation

Stebalien
Copy link
Member

fixes #668

@Stebalien Stebalien requested a review from hsanjuan July 4, 2019 19:43
@Stebalien Stebalien force-pushed the fix/host-teardown-once branch from 2251249 to 4c28cc7 Compare July 4, 2019 20:11
@Stebalien Stebalien merged commit 198633b into master Jul 4, 2019
@Stebalien Stebalien deleted the fix/host-teardown-once branch July 4, 2019 23:52
@hsanjuan
Copy link
Contributor

hsanjuan commented Jul 5, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

@hsanjuan hsanjuan Awaiting requested review from hsanjuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] libp2p host cannot be closed more than once (panic)
3 participants
@Stebalien @hsanjuan @raulk