Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase initial relay advertisement delay to 30s #534

Merged
merged 1 commit into from
Feb 14, 2019
Merged

increase initial relay advertisement delay to 30s #534

merged 1 commit into from
Feb 14, 2019

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 14, 2019

5s is too short to initialize the DHT.

@vyzo vyzo requested a review from raulk February 14, 2019 17:28
@ghost ghost assigned vyzo Feb 14, 2019
@ghost ghost added the status/in-progress In progress label Feb 14, 2019
raulk
raulk approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like these timing dependencies. We really need an event bus with a ContentRouting::Ready event that we can react to. But until then...

@vyzo vyzo merged commit ee3d862 into master Feb 14, 2019
@ghost ghost removed the status/in-progress In progress label Feb 14, 2019
@vyzo vyzo deleted the fix/relay-advertisement-delay branch February 14, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

Assignees

@vyzo vyzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzo @raulk