Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: disable black hole detection on autonat dialer #2529

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Aug 27, 2023

If the autonat server receives too many requests from private nodes, this can cause the autonat server to incorrectly skip QUIC or IPv6 dial back requests.

Fixes: #2530

@sukunrt sukunrt requested a review from marten-seemann August 28, 2023 05:54
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we're actually behind a blackhole? This means we'll report incorrect results, right?

@sukunrt
Copy link
Member Author

sukunrt commented Aug 28, 2023

Yeah, but that's existing behaviour. This is handled in AutoNAT v2, we can port the same strategy here too.
This is the relevant part: 83babed#diff-3f6648f0d98683327cfbf62cc77beaf1d5141db48e174563e17632fe9bdb9ab5

@sukunrt sukunrt merged commit b438d18 into master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autonat server should not use black hole detection
2 participants