Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: return a more meaningful error when dialing QUIC draft-29 #2524

Merged
merged 5 commits into from
Aug 25, 2023
Merged

swarm: return a more meaningful error when dialing QUIC draft-29 #2524

merged 5 commits into from
Aug 25, 2023

Conversation

marten-seemann
Copy link
Contributor

No description provided.

@marten-seemann marten-seemann linked an issue Aug 25, 2023 that may be closed by this pull request
Better error message when trying to dial /quic peer #2515
Closed
Jorropo
Jorropo reviewed Aug 25, 2023
View reviewed changes
p2p/net/swarm/swarm_dial.go Outdated Show resolved Hide resolved
p2p/net/swarm/dial_test.go Show resolved Hide resolved
@marten-seemann
Copy link
Contributor Author

Nice one, thanks @Jorropo!

Jorropo
Jorropo approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you need to go fmt since I used space instead of tabs in my suggestion.
Thx

@Jorropo
Copy link
Contributor

Jorropo commented Aug 25, 2023

Also ErrQUICDraft29 (type) is not an expression, up to you, you could do that instead:

var ErrQUICDraft29 errQUICDraft29

type errQUICDraft29 struct{}

@marten-seemann marten-seemann merged commit 4caa4e5 into master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Jorropo approved these changes

@sukunrt sukunrt sukunrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message when trying to dial /quic peer
3 participants
@marten-seemann @Jorropo @sukunrt