quic: return a more meaningful error when dialing QUIC draft-29 #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Aug 24, 2023
| @@ -21,6 +23,8 @@ func ToQuicMultiaddr(na net.Addr, version quic.VersionNumber) (ma.Multiaddr, err | |||
| switch version { | |||
| case quic.Version1: | |||
| return udpMA.Encapsulate(quicV1MA), nil | |||
| case quicDraft29: | |||
There was a problem hiding this comment.
Not sure if this is needed here, but it certainly doesn't hurt.
|
I'm not sure if this fix will still work with #2520. But that's a bug that we need to fix. |
MarcoPolo
approved these changes
Aug 24, 2023
|
With #2520, this won't work any more, because it's not the QUIC transport's responsibility any more to handle /quic addresses. Instead, the swarm would now return an @Jorropo, any thoughts? |
|
Closing. We'll solve this in the swarm after #2437 has landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2515.