Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add instance filter to all dashboards #2301

Merged
merged 2 commits into from
May 20, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented May 19, 2023

This provides an instance filter on dashboards like this:

Screenshot 2023-05-19 at 6 51 46 PM

The script I used to update these is at
https://github.com/sukunrt/go-libp2p/blob/add-instance-script/dashboards/script/script.go

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, and it works fine in the PL Grafana instance.

Any reason to change the file permissions though?
image

@sukunrt
Copy link
Member Author

sukunrt commented May 20, 2023

oh no. I didn't notice I'd updated them. Changed them back to 644 as before.

@marten-seemann marten-seemann merged commit 01651d2 into libp2p:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants