relaymanager: do not start new relay if one already exists #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
fix-relaymanager
branch
from
9c67ce1 to
4536b8e
Compare
sukunrt
force-pushed
the
fix-relaymanager
branch
from
4536b8e to
e5442ec
Compare
p2p/host/relaysvc/relay_test.go
Outdated
| func TestReachabilityChangeEvent(t *testing.T) { | ||
| h := bhost.NewBlankHost(swarmt.GenSwarm(t)) | ||
| rmgr := NewRelayManager(h) | ||
| rmgr.reachabilityChanged(network.ReachabilityPublic) |
There was a problem hiding this comment.
I have a slight preference for not calling unexported functions in tests (where possible). In this case, you could get the event bus (via h.EventBus()), and then emit reachability events.
Co-authored-by: Marten Seemann <[email protected]>
marten-seemann
approved these changes
Feb 15, 2023
p2p/host/relaysvc/relay_test.go
Outdated
| require.Eventually( | ||
| t, | ||
| func() bool { rmgr.mutex.Lock(); defer rmgr.mutex.Unlock(); return rmgr.relay != nil }, | ||
| 200*time.Millisecond, |
There was a problem hiding this comment.
Better to increase this to a second, CI is super slow (sometimes), which then leads to flaky tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2091