chore: bring examples back into repository and add tests #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To ease review, this diff shows just changes made to add tests to examples: iand/go-libp2p@iand:integrate-examples...iand:test-examples |
Stebalien
requested changes
May 8, 2021
|
I'm going to take a pass at getting CI coverage of these. |
This example doesn't actually work.
|
Ok, tested with protocol/.github#89. |
marten-seemann
approved these changes
May 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the approach discussed in #1052. Examples are now in a submodule with a replace directive that ensures they will be built using the version of go-libp2p in this repo.
Adds a test harness that enables some of the examples to be run as tests. The test harness reads log output and verifies expected log messages are present. Adding a test to an example is done by extracting the core of the example into a new function that can be called from main and from the harness. I have refactored a couple of examples to use helper functions to make them more amenable to external testing.
Fixes the relay example which was using relay discovery which was deprecated in 2020
Fixes libp2p/go-libp2p-examples#191