Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libp2phttp: Adhere to request.Context when roundtripping on a stream #2533

Closed
MarcoPolo opened this issue Aug 28, 2023 · 0 comments · Fixed by #2796
Closed

libp2phttp: Adhere to request.Context when roundtripping on a stream #2533

MarcoPolo opened this issue Aug 28, 2023 · 0 comments · Fixed by #2796
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature libp2phttp

Comments

@MarcoPolo
Copy link
Collaborator

I've left a todo in the code.

Originally posted by @marten-seemann in #2438 (comment)
@MarcoPolo MarcoPolo mentioned this issue Aug 28, 2023
Merged
@marten-seemann marten-seemann added kind/enhancement A net-new feature or improvement to an existing feature exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours labels Dec 6, 2023
@gammazero gammazero mentioned this issue May 16, 2024
Closed
gammazero added a commit that referenced this issue May 16, 2024
@gammazero
Adhere to request.Context when roundtripping on a stream
f5dc013 
This allows HTTP request timeout and cancellation to work.

Fixes #2533
@gammazero gammazero mentioned this issue May 16, 2024
Merged
gammazero added a commit that referenced this issue May 16, 2024
@gammazero
Adhere to request.Context when roundtripping on a stream
1ec7ce7 
This allows HTTP request timeout and cancellation to work.

Fixes #2533
MarcoPolo added a commit that referenced this issue May 17, 2024
@gammazero @MarcoPolo
Adhere to request.Context when roundtripping on a stream (#2796)
547f9db 
* Adhere to request.Context when roundtripping on a stream

This allows HTTP request timeout and cancellation to work.

Fixes #2533

* Attempt to cancel the read by setting the read deadline

* Don't spawn a goroutine in read

---------

Co-authored-by: Marco Munizaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature libp2phttp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adhere to request.Context when roundtripping on a stream libp2p/go-libp2p
2 participants
@MarcoPolo @marten-seemann