Skip to content

Commit

Permalink
fix: remove more field
Browse files Browse the repository at this point in the history
We no longer need it now that we keep reading till the stream closes.
  • Loading branch information
Stebalien committed Jun 3, 2020
1 parent 513e13d commit b22add8
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 70 deletions.
1 change: 0 additions & 1 deletion p2p/protocol/identify/id.go
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,6 @@ func (ids *IDService) writeChunkedIdentifyMsg(c network.Conn, snapshot *identify
return writer.WriteMsg(mes)
}
mes.SignedPeerRecord = nil
mes.More = true
if err := writer.WriteMsg(mes); err != nil {
return err
}
Expand Down
80 changes: 18 additions & 62 deletions p2p/protocol/identify/pb/identify.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions p2p/protocol/identify/pb/identify.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ syntax = "proto2";

package identify.pb;

import "github.com/gogo/protobuf/gogoproto/gogo.proto";

message Delta {
// new protocols now serviced by the peer.
repeated string added_protocols = 1;
Expand Down Expand Up @@ -39,11 +37,6 @@ message Identify {
// a delta update is incompatible with everything else. If this field is included, none of the others can appear.
optional Delta delta = 7;

// more is set to true by a peer to indicate to the receiver that the signed record is absent in the current message
// and the peer should read the next message from the stream to fetch it.
// This is done because messages with signed records can exceed the legacy message size of 2K bytes.
optional bool more = 9 [(gogoproto.nullable) = false];

// signedPeerRecord contains a serialized SignedEnvelope containing a PeerRecord,
// signed by the sending node. It contains the same addresses as the listenAddrs field, but
// in a form that lets us share authenticated addrs with other peers.
Expand Down

0 comments on commit b22add8

Please sign in to comment.