fix flaky TestAcceptQueueBacklogged test

libp2p · Dec 12, 2021 · acbe092 · acbe092
1 parent a2b5749
commit acbe092
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/listener_test.go b/listener_test.go
@@ -289,9 +289,7 @@ func TestAcceptQueueBacklogged(t *testing.T) {
 	doDial := func() {
 		conn, err := dial(t, upgrader, ln.Multiaddr(), id)
 		errCh <- err
-		if conn != nil {
-			_ = conn.Close()
-		}
+		t.Cleanup(func() { conn.Close() })
 	}
 
 	for i := 0; i < st.AcceptQueueLength; i++ {
@@ -309,7 +307,7 @@ func TestAcceptQueueBacklogged(t *testing.T) {
 	// accept a single connection. Now the new connection should be set up, and fill the queue again
 	conn, err := ln.Accept()
 	require.NoError(err)
-	_ = conn.Close()
+	require.NoError(conn.Close())
 
 	require.Eventually(func() bool { return len(errCh) == st.AcceptQueueLength+1 }, 2*time.Second, 100*time.Millisecond)
 }