This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Export methods to allow generating custom certificates #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: libp2p/go-libp2p#1538
This PR refactors
keyToCertificate
into 3 methodsDefaultCertTemplate
(exported), which returns the default certificate template used to generate the self-signed certificate,generateSignedExtension
, which generates the signed extensionkeyToCertificate
, which accepts anx509.Certificate
template, adds the signed extension and returns thetls.Certificate
object.This PR also adds a new optional parameter to
NewIdentity
, which can provide a custom certificate template.The changes are intended to be backwards compatible and add the ability for a caller to specify the x509 certificate fields they wish to include in the generated certificate.