This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
use a prefix when signing the public key #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
approved these changes
Mar 14, 2019
Stebalien
reviewed
Mar 14, 2019
There was a problem hiding this comment.
We could include the version but I don't believe it's necessary. Someone could try an upgrade/downgrade attack but they'd still need our ephemeral private key to sign the cert itself.
Of course, we could just include it anyways to be safe, it can't hurt. I'll leave that up to you.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking of including the version here as well, or as least the string representation of the OID of the certificate extension, e.g. "libp2p-tls-handshake 1.3.6.1.4.1.53594.1.1:" WDYT?