This repository has been archived by the owner on May 26, 2022. It is now read-only.
Treat transient connections as opt-in when opening new streams #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still need the code to mark limited Relay connections as Transient. How and where in the code do you plan to do that without leaking the idea of limited Relays to the Swarm ? |
|
The relay dialer/listener constructs the Conn object, so it can mark itself when it knows it's transient. |
|
retract that, the swarm creates the stat object -- we need a mechanism to pass stuff from the transport all the way up to the swarm. |
|
added threading of stat if available from the transport conn. |
6 tasks
23 tasks
aarshkshah1992
approved these changes
Feb 17, 2021
vyzo
force-pushed
the
feat/transient-conns
branch
from
94302e6 to
5c3c0a0
Compare
|
Should I go ahead and merge this ? |
|
waiting for travis, I will merge and cut release. |
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for transient connections with opt-in semantics; when the best connection to a peer is transient, then only open a stream if the user is prepared to deal with it and has specified the relevant context option.
Rationale: many protocols may not be prepared to deal with transient connections; this makes it explicit opt-in to protect them and also eliminate interference with connection upgrade attempts.
depends on libp2p/go-libp2p-core#175
TODO