This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
fix RandTestKeyPair on windows #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
suggested changes
Jan 31, 2018
test/utils.go
Outdated
|
|
||
| // workaround for low time resolution | ||
| seed += (1 << 32) * generatedPairs | ||
| generatedPairs++ |
There was a problem hiding this comment.
This will need to use an atomic. We have some packages (e.g., swarm) that run tests in parallel.
magik6k
force-pushed
the
fix/windows-tests-utils
branch
from
a8ec7a3 to
87715ad
Compare
|
Needs a |
magik6k
force-pushed
the
fix/windows-tests-utils
branch
from
87715ad to
a17daf2
Compare
Stebalien
approved these changes
Feb 1, 2018
Stebalien
force-pushed
the
fix/windows-tests-utils
branch
from
a17daf2 to
29ee8c4
Compare
|
Fixed the merge conflicts. @magik6k I know I'm probably being a hypocrite here but... please try to avoid making changes other than updating dependencies in a gx release commit (also, try to avoid multiple releases in a single PR, it gets a bit messy). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution of
time.Now().UnixNano()on windows is quite low, which results in generating identical key pairs when this is called in quick succession.