Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate go-libp2p-core and use go-libp2p instead #109

Merged
merged 4 commits into from
Sep 1, 2022
Merged

deprecate go-libp2p-core and use go-libp2p instead #109

merged 4 commits into from
Sep 1, 2022

Conversation

nisainan
Copy link
Contributor

glad to see libp2p is uniting repositories together and be happy to join it.

  • deprecate go-libp2p-core and use go-libp2p instead
  • replace some deprecated funtions with new
  • annotation formated

Stebalien
Stebalien requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, otherwise LGTM.

And thanks! Making mistakes is all a part of the master plan so we can fix them and make everyone happy 😛.

peerdiversity/filter.go Outdated Show resolved Hide resolved
generate/main.go Outdated Show resolved Hide resolved
util.go Outdated Show resolved Hide resolved
@nisainan
Copy link
Contributor Author

nisainan commented Sep 1, 2022

thanks for your advice and tolerance, hoping I can do better next time.

@nisainan nisainan requested a review from Stebalien September 1, 2022 02:29
Stebalien
Stebalien reviewed Sep 1, 2022
View reviewed changes
peerdiversity/filter.go Outdated Show resolved Hide resolved
@Stebalien
Copy link
Member

thanks for your advice and tolerance, hoping I can do better next time.

Nah, you're code was great.

@nisainan nisainan requested a review from Stebalien September 1, 2022 02:51
@Stebalien Stebalien merged commit 03c1432 into libp2p:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisainan @Stebalien