-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: upgrade build to include go1.21 #890
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
8cf5bbc
v2: upgrade to go1.21
iand b1b4661
Add uci config
iand 3997993
Use newer uci actions
iand 77ca4ec
Fix merge conflict
iand d7feea9
Use v2 working directory in actions
iand 1299359
Set go-version input in actions
iand ce1fa35
Set go-version input in actions
iand 52555e3
Use go 1.20.8 in actions
iand 9838121
Use go 1.21.1 and relative working directory
iand f08a1ea
Try default working directory on job
iand bf14d3e
Remove uci.yaml which is not supported yet
iand 0e6e4d2
Try default working directory on job
iand 318fdaa
Try default working directory as input
iand c5768c2
Restore uci.yaml
iand 576d604
Restore uci.yaml
iand 54cc8e8
Use modified go-check
iand 3826f9d
Use modified go-test
iand f131d09
Fix go-test
iand b8662b9
Fix go-test
iand e94e01e
Fix go-test
iand 22ad479
Merge branch 'v2-develop' into v2-go121
iand 960eca4
Restore libp2p 0.30.0
iand 60e8ff2
go mod tidy
iand ebff55e
Remove nil error return from DefaultConfig
iand 45dbf25
use mock clock for IPNS record generation (#894)
dennis-tra f607a79
Use MapDatastore for provider backend tests instead of leveldb (#896)
dennis-tra 36328b1
revert some merge residuals
dennis-tra 961da3e
style: minor coding clean up (#898)
dennis-tra f28c2fc
Target go language version 1.20 and add 1.20.8 to build matrix
iand 7e13876
Target go language version 1.20 and add 1.20.8 to build matrix
iand 5665cda
WIP
iand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| files: # Configure what Unified CI templates should be used for your repository; defaults to primary language default fileset | ||
| - .github/workflows/go-check.yml | ||
| - .github/workflows/go-test.yml | ||
| force: true # Configure whether Unified CI should overwrite existing workflows; defaults to false | ||
| versions: | ||
| go: 1.21 # Configure what version of Go should be used; defaults to oldstable | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should include Go 1.20 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually no-op. uci.yaml isn't used by go-check or go-test (see https://filecoinproject.slack.com/archives/C03KLC57LKB/p1694518386936719?thread_ts=1694429677.253269&cid=C03KLC57LKB) Also we have customised both to pass in a v2 working directory, so this is irrelevant.
As mentions in the PR description the plan is to get working builds during v2 development and then integrate the CI with version 1 when we are closer to completion. Right now we are in the frustrating situation of not ever having clean builds.