fullrt dht bug fixes #719
Merged
fullrt dht bug fixes #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
previously approved these changes
May 26, 2021
gammazero
approved these changes
May 26, 2021
|
@aschmahmann I realized when I stopped initializing the timer to |
aschmahmann
commented
May 26, 2021
aschmahmann
commented
May 26, 2021
gammazero
requested changes
May 26, 2021
aschmahmann
commented
May 26, 2021
aschmahmann
commented
May 26, 2021
…least 100 messages to send
…ppy mode The execOnMany function was able to exit prematurely, leaving its child goroutines running. These would write to a channel that closed after execOnMany returned in findProvidersAsyncRoutine. The function is now able to run both in a sloppy mode where it allows goroutines to be cleaned up after the function has completed as well a safer non-sloppy mode where goroutines will complete before the function returns. The sloppy mode is used for DHT "get" operations like FindProviders and SearchValues whereas the non-sloppy mode is used for "put" operations like PutValue and Provide (along with their bulk operation equivalents). This fixes ipfs/kubo#8146
aschmahmann
force-pushed
the
fix/fullrt-log-progress
branch
from
1e791eb to
daab800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #717, although this PR has been updated to fix issues with #717 in addition to a few more