feat: protect all peers in low buckets, tag everyone else with 5 #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anything else is easy to game. This way, we remain connected to the core peers and slightly prefer all others. Pruning doesn't really matter as we'll just reconnect. The only concern is that this will lock in 40 connections. However, that's nothing for libp2p anyways. and the DHT will create that many connections _just_ for a single query.
|
Discussed with @aschmahmann on a sync call. Rational:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything else is easy to game. This way, we remain connected to the core peers and slightly prefer all others.
Pruning doesn't really matter as we'll just reconnect. The only concern is that this will lock in 40 connections. However, that's nothing for libp2p anyways. and the DHT will create that many connections just for a single query.