fix all flaky tests #628
Merged
fix all flaky tests #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fail if the routing tables aren't well-formed. It turns out there were a couple of issues with this test: 1. It used too many file descriptors. 2. It tried to query the DHT without bootstrapping any nodes. That's never going to work.
Stebalien
force-pushed
the
test/fix-hung-test
branch
from
6885b27 to
6c70c2f
Compare
Just wait for peers to fill up the routing table.
aschmahmann
reviewed
May 6, 2020
ext_test.go
Outdated
Comment on lines
50
to
53
| // Wait at most 100ms for a peer in our routing table. | ||
| for i := 0; i < 100 && d.routingTable.Size() == 0; i++ { | ||
| time.Sleep(10 * time.Millisecond) | ||
| } |
There was a problem hiding this comment.
This test still fails: #623 (comment). I got
=== RUN TestHungRequest
TestHungRequest: ext_test.go:69: expected to fail with deadline exceeded, got: %!s(<nil>)
TestHungRequest: ext_test.go:73: GetClosestPeers should not have returned yet failed to find any peer
in table
TestHungRequest: ext_test.go:83: expected peers in the routing table
--- FAIL: TestHungRequest (1.16s)
There was a problem hiding this comment.
I'm pretty sure this was failing for me, but maybe I had some stale state. Will try and run the test more times and report back.
There was a problem hiding this comment.
You definitely had the change ("expected peers in the routing table" is new).
There was a problem hiding this comment.
Ah, you were probably right about the identify race.
There was a problem hiding this comment.
k, just as a heads up though it's much harder to reproduce the error locally now then previously
There was a problem hiding this comment.
Ok, I think I've fixed it now by just not connecting till everything has been setup.
aschmahmann
reviewed
May 6, 2020
Stebalien
commented
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #623
fixes #541
fixes #517