fix: re-validate peers whenever their state changes #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When a peer changes their listening addresses, we need to re-run our routing table filters, possibly removing them. 2. When a peer _starts_ supporting the DHT protocol, we need to add them to our routing table. Previously, we'd only do the inverse.
They've told us better ones via identify.
willscott
reviewed
Apr 25, 2020
|
|
||
| func (dht *IpfsDHT) maybeAddAddrs(p peer.ID, addrs []ma.Multiaddr, ttl time.Duration) { | ||
| // Don't add addresses for self or our connected peers. We have better ones. | ||
| if p == dht.self || dht.host.Network().Connectedness(p) == network.Connected { |
There was a problem hiding this comment.
not adding addresses because the peer is connected seems counter intuitive. when are the peer's addresses added in that case?
There was a problem hiding this comment.
Because we don't want someone else to tell us the wrong addresses for the peer, overwriting the good ones in our peerstore.
willscott
approved these changes
Apr 25, 2020
|
@aarshkshah1992 I'd like you to take a look at this after the fact. I think I got this right, but I want to double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p#898