Set record handlers for the default protocol prefix #560
Conversation
dht_options.go
Outdated
| c.validator = record.NamespacedValidator{ | ||
| "pk": record.PublicKeyValidator{}, | ||
| } |
There was a problem hiding this comment.
We've had this in in the past, but I'm not quite sure why... does anyone even use this?
dht_options.go
Outdated
| // on other configuration parameters (e.g. optA is by default 2x optB) and/or on the Host | ||
| func (c *config) applyFallbacks(h host.Host) { | ||
| if c.validator == nil { | ||
| if c.protocolPrefix == DefaultPrefix { |
There was a problem hiding this comment.
Is it too weird to only have this default set for the /ipfs prefix instead of for everyone? This is the way that makes the least changes to any users of the library, but is also kind of unintuitive/unhelpful if someone wants to fork the /ipfs network.
aschmahmann
force-pushed
the
feat/ipns-default
branch
from
607d741 to
df46bee
Compare
dht_options.go
Outdated
| // For the default protocol prefix it defaults to a namespaced validator that | ||
| // supports validating both public key and IPNS records |
There was a problem hiding this comment.
This is the weird comment we sort of have to leave now if we stick with this approach https://github.com/libp2p/go-libp2p-kad-dht/pull/560/files#r404190615
There was a problem hiding this comment.
I updated things to make them a little simpler and more compliant, but now this comment isn't 100% accurate because the internals have more subtleties. Thoughts?
dht_options.go
Outdated
| nsval, ok := c.validator.(record.NamespacedValidator) | ||
| if ok { | ||
| nsval["ipns"] = ipns.Validator{KeyBook: h.Peerstore()} | ||
| } |
There was a problem hiding this comment.
I don't know if this is quite what we want... it seems reasonably close though
…alidator defaults are modified in which case neither of them are added
…Validator has been changed, in which case neither of them are added. Simply adding additional NamespacedValidators does not remove the pk or ipns validators
dht_options.go
Outdated
| // | ||
| // Example: Given a validator registered as `NamespacedValidator("ipns", | ||
| // myValidator)`, all records with keys starting with `/ipns/` will be validated | ||
| // with `myValidator`. | ||
| func NamespacedValidator(ns string, v record.Validator) Option { | ||
| return func(c *config) error { | ||
| if !c.validatorChanged { | ||
| if ns == "pk" { | ||
| return fmt.Errorf("cannot override the pk namespace without first changing the Validator") |
… other validators, however they are of an invalid type then they will fail if using the default /ipfs protocol prefix
The default protocol prefix
/ipfsassumes the existence of the "pk" and "ipns" namespaces. These are now both constructed and added to the DHT if no Validators are specified and the protocol prefix is/ipfs.The current behavior of having the "pk" namespace enabled by default is still there though.