disable flaky tests

libp2p · Jun 15, 2021 · 6a933c0 · 6a933c0
1 parent 0cbe032
commit 6a933c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/dht_test.go b/dht_test.go
@@ -388,6 +388,7 @@ func TestValueSetInvalid(t *testing.T) {
 }
 
 func TestContextShutDown(t *testing.T) {
+	t.Skip("This test is flaky, see https://github.com/libp2p/go-libp2p-kad-dht/issues/724.")
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 
@@ -412,6 +413,8 @@ func TestContextShutDown(t *testing.T) {
 }
 
 func TestSearchValue(t *testing.T) {
+	t.Skip("This test is flaky, see https://github.com/libp2p/go-libp2p-kad-dht/issues/723.")
+
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 

diff --git a/rtrefresh/rt_refresh_manager_test.go b/rtrefresh/rt_refresh_manager_test.go
@@ -15,6 +15,8 @@ import (
 )
 
 func TestSkipRefreshOnGapCpls(t *testing.T) {
+	t.Skip("This test is flaky, see https://github.com/libp2p/go-libp2p-kad-dht/issues/722.")
+
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 	local := test.RandPeerIDFatal(t)
@@ -39,8 +41,8 @@ func TestSkipRefreshOnGapCpls(t *testing.T) {
 			p, err := rt.GenRandPeerID(uint(u))
 			require.NoError(t, err)
 			b, err := rt.TryAddPeer(p, true, false)
-			require.True(t, b)
 			require.NoError(t, err)
+			require.True(t, b)
 			return nil
 		}
 	}