This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a logic bug here where it was expected that a
StrategyFactory
could be used to create multiple instances of aBackoffStrategy
. However, eachBackoffStrategy
created by the factory shared the same instance ofrand.Rand
which is not thread-safe unless the underlyingrand.Source
is thread-safe.Took a stab at a fix here. Given that the interface has to break and that I'd like to fix this asap since it showed up in production #53, here are a few options:
rand.Int63()
as the seed)BackoffStrategy
generated from the factory.Rand
using a seed taken from the Factory-sharedRand
.3+4 seem like the most appealing options to me. I've chosen 3 over 4 in this PR because for now I'd prefer to run into lock contention on the Factory then have lots of allocations for new Rand's. I'm definitely up for better suggestions as long as they don't involve a huge refactor since we're a bit time bound here.