add an error return value to the constructor #87

marten-seemann · 2021-11-26T06:45:24Z

No description provided.

vyzo

this will break all users, can we add a second constructor instead?

marten-seemann · 2021-11-26T07:41:17Z

That's what we have semver for. This release will have more breaking changes.

marten-seemann · 2021-11-28T14:10:09Z

@vyzo Now that we've decided to cut a new go-libp2p release, can I get your approval for this PR?

marten-seemann force-pushed the constructor-return-value branch 2 times, most recently from 00f5050 to 5be7812 Compare November 26, 2021 06:52

marten-seemann requested a review from vyzo November 26, 2021 06:58

vyzo reviewed Nov 26, 2021

View reviewed changes

marten-seemann force-pushed the constructor-return-value branch from 5be7812 to cceb5e3 Compare November 28, 2021 14:09

marten-seemann requested a review from vyzo November 28, 2021 14:09

vyzo approved these changes Nov 28, 2021

View reviewed changes

marten-seemann force-pushed the constructor-return-value branch 2 times, most recently from 7119513 to bd5780f Compare November 29, 2021 05:48

add an error return value to the constructor

3c31fe5

marten-seemann force-pushed the constructor-return-value branch from bd5780f to 3c31fe5 Compare November 29, 2021 05:50

marten-seemann merged commit 052c857 into master Nov 29, 2021

marten-seemann deleted the constructor-return-value branch November 29, 2021 06:01

Provide feedback