Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

decaying tags: support removal and closure. #72

Merged
merged 2 commits into from
May 15, 2020
Merged

decaying tags: support removal and closure. #72

merged 2 commits into from
May 15, 2020

Conversation

raulk
Copy link
Member

@raulk raulk commented May 14, 2020

This PR introduces two features to decaying tags:

  • Explicitly remove a decaying tag from a peer.
  • Kill/close a decaying tag, dropping its tracking and erasing it from all peers.

See libp2p/go-libp2p-core#151 for interface changes.

@raulk raulk mentioned this pull request May 14, 2020
Merged
@raulk raulk requested a review from yusefnapora May 14, 2020 19:02
yusefnapora
yusefnapora approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

decay_test.go Outdated Show resolved Hide resolved
@raulk @yusefnapora
fix comment in test.
0650f48 
Co-authored-by: Yusef Napora <[email protected]>
@raulk raulk merged commit d0cf428 into master May 15, 2020
@raulk raulk deleted the feat/decaying-tags-removal-close branch May 15, 2020 08:27
@raulk raulk mentioned this pull request May 15, 2020
Merged
@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yusefnapora yusefnapora yusefnapora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulk @yusefnapora