This repository has been archived by the owner on May 11, 2022. It is now read-only.
fix stream deadlines #107
Merged
fix stream deadlines #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A malicious peer could also block writes to a stream (for example by withholding flow control credit).
marten-seemann
force-pushed
the
fix-deadlines
branch
from
afcab38 to
2e692c3
Compare
Stebalien
approved these changes
Aug 25, 2021
| "github.com/libp2p/go-msgio/protoio" | ||
| ma "github.com/multiformats/go-multiaddr" | ||
| ) | ||
|
|
||
| var streamReadTimeout = 60 * time.Second | ||
| var streamTimeout = 60 * time.Second |
There was a problem hiding this comment.
we can probably reduce this to 5-10 seconds as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A malicious peer could also block writes to a stream (for example by withholding flow control credit). We therefore need to set both read and write deadlines.
This PR also adds a deadline to streams opened by the client, and adds a missing stream reset in one of the error cases.