Enable tests #6
Enable tests #6
Conversation
.travis.yml
Outdated
| sudo: false | ||
| os: | ||
| - linux | ||
| - osx |
There was a problem hiding this comment.
We don't need to test this on macos. Historically, the queue has been really long and this has no os specific code.
There was a problem hiding this comment.
My bad; I copied it from another repo without thinking too much about it.
There was a problem hiding this comment.
(which repo? We have a bunch of outdate CI scripts...)
There was a problem hiding this comment.
I think I got it from the go-maddr-filter repo: https://github.com/libp2p/go-maddr-filter/blob/master/.travis.yml.
I can remove the osx build from there as well (and remove it from other repos that don't have OS specific code as I encounter such instances).
There was a problem hiding this comment.
If you're willing to spend the time at it, that would be great! We usually just wait for it to sufficiently annoy someone.
|
|
||
| install: | ||
| before_install: | ||
| - make deps |
There was a problem hiding this comment.
We want to replace the install section.
README.md
Outdated
| @@ -1,7 +1,10 @@ | |||
| go-buffer-pool | |||
| ================== | |||
|
|
|||
| [](https://protocol.ai) | |||
| [](http://protocol.ai) | |||
There was a problem hiding this comment.
Theses should all be https (we probably need to normalize our repos).
|
Thanks! |
| @@ -27,7 +27,7 @@ func TestAllocations(t *testing.T) { | |||
| runtime.GC() | |||
| runtime.ReadMemStats(&m2) | |||
| frees := m2.Frees - m1.Frees | |||
| if frees > 100 { | |||
| if frees > 1000 { | |||
| t.Fatalf("expected less than 100 frees after GC, got %d", frees) | |||
There was a problem hiding this comment.
hm this line is out of date. Seems like an unreliable test anyway?
There was a problem hiding this comment.
It's timing related. Basically, I just want to make sure that the pool is actually saving us allocations.
Fixes #5 and enables code coverage metrics.