Update required CI checks for rust-libp2p

[thomaseizinger]

Summary

Companion PR for libp2p/rust-libp2p#3090.

Why do you need this?

What else do we need to know?

DRI: myself

Reviewer's Checklist

• It is clear where the request is coming from (if unsure, ask)
• All the automated checks passed
• The YAML changes reflect the summary of the request
• The Terraform plan posted as a comment reflects the summary of the request

[github-actions]

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_branch_protection.this["rust-libp2p:master"] will be updated in-place
  ~ resource "github_branch_protection" "this" {
        id                              = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMjM0NjQ0MA=="
        # (9 unchanged attributes hidden)


      ~ required_status_checks {
          ~ contexts = [
              - "Build and test (--all-features)",
              - "Build and test (--benches --all-features)",
              - "Build and test (--no-default-features)",
              - "Build on WASM (wasm32-unknown-emscripten)",
              - "Build on WASM (wasm32-wasi)",
              + "Compile on wasm32-unknown-emscripten",
              + "Compile on wasm32-unknown-unknown",
              + "Compile on wasm32-wasi",
              + "Compile on x86_64-apple-darwin",
              + "Compile on x86_64-pc-windows-msvc",
              + "Compile with select features (mdns tcp dns async-std)",
              + "Compile with select features (mdns tcp dns tokio)",
              + "IPFS Integration tests",
              - "Integration tests",
              + "Test libp2p",
              + "Test libp2p-autonat",
              + "Test libp2p-core",
              + "Test libp2p-dcutr",
              + "Test libp2p-deflate",
              + "Test libp2p-dns",
              + "Test libp2p-floodsub",
              + "Test libp2p-gossipsub",
              + "Test libp2p-identify",
              + "Test libp2p-kad",
              + "Test libp2p-mdns",
              + "Test libp2p-metrics",
              + "Test libp2p-mplex",
              + "Test libp2p-noise",
              + "Test libp2p-ping",
              + "Test libp2p-plaintext",
              + "Test libp2p-pnet",
              + "Test libp2p-relay",
              + "Test libp2p-rendezvous",
              + "Test libp2p-request-response",
              + "Test libp2p-swarm",
              + "Test libp2p-swarm-derive",
              + "Test libp2p-tcp",
              + "Test libp2p-tls",
              + "Test libp2p-uds",
              + "Test libp2p-wasm-ext",
              + "Test libp2p-websocket",
              + "Test libp2p-yamux",
              + "Test multistream-select",
              + "Test prost-codec",
              + "Test rw-stream-sink",
              - "check-clippy",
              + "clippy (stable)",
                # (2 unchanged elements hidden)
            ]
            # (1 unchanged attribute hidden)
        }
        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

[thomaseizinger]

Oh wow, is a499ace some kind of auto-formatting bot? Interesting.

I didn't make that commit :)

[galargh]

Oh wow, is a499ace some kind of auto-formatting bot? Interesting.

I didn't make that commit :)

Yes! We can define custom actions which can further modify the YAML config whenever it changes. They are defined in https://github.com/libp2p/github-mgmt/blob/master/scripts/src/actions/fix-yaml-config.ts. As you can see, one of them is format() :)

I see the commit is associated with you rather than with the bot account. I'll have a look at it when I have a moment.

[mxinden]

Thanks for following this all the way through @thomaseizinger! Just one question.

[mxinden]

Do I understand correctly that each time we add a new crate we have to touch this file? I am assuming there is no out-out instead of opt-in for required status checks?

[thomaseizinger]

By default, status checks are not required so we don't need to touch the file unless we want them to be required!

[mxinden]

This looks good to me. Thanks @thomaseizinger. And also thanks @libp2p/ipdx for codifying these configurations!

[mxinden]

If I am not mistaken, this should only be merged once libp2p/rust-libp2p#3090 is merged.

[thomaseizinger]

If I am not mistaken, this should only be merged once libp2p/rust-libp2p#3090 is merged.

It is the other way round. We have to merge this first so we can even merge libp2p/rust-libp2p#3090 (unless you force-merge that one with admin priviledges).

Once this is merged, nothing else can merge apart from libp2p/rust-libp2p#3090.

[thomaseizinger]

@mxinden libp2p/rust-libp2p#3090 is good to merge. Can we merge here? (I don't have the rights to merge.)