Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mention workflow name in expected check #113

Merged
merged 3 commits into from
Feb 5, 2023

Conversation

thomaseizinger
Copy link
Contributor

Summary

GitHub is a bit confusing in how they name checks but it turns out, one must not include the workflow name otherwise libp2p/rust-libp2p#3414 doesn't pass.

Why do you need this?

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_branch_protection.this["rust-libp2p:master"] will be updated in-place
  ~ resource "github_branch_protection" "this" {
        id                              = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMjM0NjQ0MA=="
        # (9 unchanged attributes hidden)


      ~ required_status_checks {
          ~ contexts = [
              - "Interoperability Testing / Run multidimensional interoperability tests",
              + "Run multidimensional interoperability tests",
                # (44 unchanged elements hidden)
            ]
            # (1 unchanged attribute hidden)
        }
        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@thomaseizinger
Copy link
Contributor Author

@galargh Please merge this ASAP.

@p-shahi p-shahi merged commit 51ed5ec into libp2p:master Feb 5, 2023
@p-shahi
Copy link
Member

p-shahi commented Feb 5, 2023

Saw the Asap so I merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants