Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp2p: rename rust-libp2p interop workflow #111

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

jxs
Copy link
Member

@jxs jxs commented Feb 2, 2023

Summary

Renames the rust-libp2p interop workflow to accomodate for libp2p/rust-libp2p#3414

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@jxs jxs requested review from a team as code owners February 2, 2023 19:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_branch_protection.this["rust-libp2p:master"] will be updated in-place
  ~ resource "github_branch_protection" "this" {
        id                              = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMjM0NjQ0MA=="
        # (9 unchanged attributes hidden)


      ~ required_status_checks {
          ~ contexts = [
              + "Interoperability Testing / Run multidimensional interoperability tests",
              - "Run multidimensional interoperability tests / Run testplans test",
                # (44 unchanged elements hidden)
            ]
            # (1 unchanged attribute hidden)
        }
        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@galargh
Copy link
Contributor

galargh commented Feb 3, 2023

@jxs Ping me when you want it merged :)

@jxs
Copy link
Member Author

jxs commented Feb 3, 2023

Thanks Piotr! CC @thomaseizinger

@thomaseizinger
Copy link
Contributor

You are welcome to go ahead on both @jxs!

@jxs
Copy link
Member Author

jxs commented Feb 3, 2023

Thanks! Can we then merge @galargh?

@galargh galargh merged commit ff588d0 into libp2p:master Feb 3, 2023
@galargh
Copy link
Contributor

galargh commented Feb 3, 2023

@jxs Done!

@thomaseizinger
Copy link
Contributor

For some reason, GitHub doesn't match the running job to the expected one: libp2p/rust-libp2p#3414

Do you have any idea what is going on here @galargh?

@thomaseizinger
Copy link
Contributor

Ah I know what is wrong. Will open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants