Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflow #209

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

fourlastor
Copy link
Contributor

@fourlastor fourlastor commented Nov 7, 2024

This PR adds a release workflow which is triggered upon pushing a new tag

Copy link
Member

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I should approve or block this until I hear from other people in the organization about our GH Actions protocol. I don't know enough about GH Actions to make an informed decision on my own.

- name: Publish package
run: ./gradlew packageWinX64 packageLinuxX64
- name: Release
uses: softprops/action-gh-release@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know the first thing about GH Actions, but since this is on the libgdx organization now, I think I need to get the OK from @Tom-Ski or someone else in the org before doing anything with third-party actions. I don't even know if softprops is third-party...

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
- name: Publish package
run: ./gradlew packageWinX64 packageLinuxX64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to run ./gradlew clean first, right? Because each run is in a container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct

@fourlastor
Copy link
Contributor Author

@tommyettinger
Copy link
Member

This looks really clean and nice! I do want to hear from someone else in the organization about our policies for GH Actions and whether this looks clean and nice to them, so I guess I'll ping @MobiDevelop and @Tom-Ski .

@MobiDevelop
Copy link
Member

While I don't have a whole lot of experience with GH Actions... I don't personally have any problem with third party actions, presuming they are actively maintained and don't have any known security issues. I don't currently have time to review the action in question, but probably best that someone does so we have a good gauge on it.

@fourlastor
Copy link
Contributor Author

I can testify on the actively maintained (the repository is updated quite often), as I've been using this action for quite some years on personal projects. Cannot vouch for the security part as that's not my area of expertise

@tommyettinger
Copy link
Member

OK, this has been sitting for almost a month, and nobody has complained about it yet. I'll merge and we'll see how this goes when I push a new release.

@tommyettinger tommyettinger merged commit ef686a4 into libgdx:master Dec 6, 2024
2 checks passed
@fourlastor fourlastor deleted the release-on-tag branch December 6, 2024 10:01
@SonicGDX
Copy link

SonicGDX commented Dec 7, 2024

Seems that the organization blocks unverified third-party actions. https://github.com/libgdx/gdx-liftoff/actions/runs/12210843035

@tommyettinger
Copy link
Member

Yep... Not sure what to do here, I think this unverified action is actually the GitHub-recommended replacement for one of their deprecated actions, so it is probably fine to permit it. I'd want to find docs for that, though.

@SonicGDX
Copy link

SonicGDX commented Dec 8, 2024

I think this unverified action is actually the GitHub-recommended replacement for one of their deprecated actions, so it is probably fine to permit it. I'd want to find docs for that, though.

It appears that is the case. They don't explicitly endorse it but they do list it alongside 3 other similar actions as being "Maintained Actions".

GitHub Action - Releases API

Please note: This repository is currently unmaintained by a team of developers at GitHub. The repository is here and you can use it as an example, or in Actions. However please be aware that we are not going to be updating issues or pull requests on this repository.

Maintained Actions:

elgohr/Github-Release-Action
marvinpinto/action-automatic-releases
softprops/action-gh-release
ncipollo/release-action

To reflect this state we’ve marked this repository as Archived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants