Skip to content

Backport PR#1204 into 1.10.x #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vik748
Copy link

@vik748 vik748 commented Apr 14, 2025

Fixes #1203 - Do not check for sanitizers if they are not enabled

@vik748 vik748 changed the title Backport #1204 into 1.10.x Backport PR#1204 into 1.10.x Apr 14, 2025
@vik748 vik748 changed the title Backport PR#1204 into 1.10.x Backport https://github.com/libcpr/cpr/pull/1204 into 1.10.x Apr 14, 2025
@vik748 vik748 changed the title Backport https://github.com/libcpr/cpr/pull/1204 into 1.10.x Backport !1204 into 1.10.x Apr 14, 2025
@vik748 vik748 changed the title Backport !1204 into 1.10.x Backport PR#1204 into 1.10.x Apr 14, 2025
@COM8
Copy link
Member

COM8 commented Apr 20, 2025

1.10.x is not supported any more and I'm not planning to do a new release on the 1.10.x branch. Any reason you are targeting it instead of the 1.11.x branch?

Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and will merge once I got more information.

@vik748
Copy link
Author

vik748 commented Apr 20, 2025

We use influxdb which uses this. And we use Ubuntu 20.04 since we use ROS1. Influxdb doesn't build with 1.11.x on Ubuntu 20.04.

@COM8 COM8 merged commit 7fa4673 into libcpr:1.10.x Apr 21, 2025
@vik748 vik748 deleted the feature/backport_more-reliable-sanitizer-checks branch April 21, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants