Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/c: Build bpftool submodule in cmake #73

Merged
merged 1 commit into from
May 25, 2022
Merged

examples/c: Build bpftool submodule in cmake #73

merged 1 commit into from
May 25, 2022

Conversation

JackyYin
Copy link
Contributor

Ref: #70.

Because tools/bpftool no longer exists, we need to build bpftool from git submodule and set the correct executable path in cmake variable BPFOBJECT_BPFTOOL_EXE.

@JackyYin
Copy link
Contributor Author

JackyYin commented May 19, 2022 •
edited
Loading

BTW, seems like we can remove the STEP_TARGETS in ExternalProject_Add and this line also: add_dependencies(${app_stem}_skel libbpf-build) because libbpf always built before examples even if I remove these lines.

Do you think we can remove them in this PR?

@JackyYin
Copy link
Contributor Author

JackyYin commented May 25, 2022 •
edited
Loading

Hello @anakryiko,
Could you give some suggestions about this PR?
I wonder what can I do to get it merged.
Thanks a lot!

anakryiko
anakryiko requested changes May 25, 2022
View reviewed changes
Copy link
Member

@anakryiko anakryiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this follows the approach for building libbpf so looks sane to me. Please fix the typo and can you also add Signed-off-by: with your full name and email just like libbpf/kernel commits have it? Thanks!

@JackyYin
examples/c: Build bpftool submodule in cmake
d5b9c6e 
Add bpftool submodule as an ExternalProject to generate bpftool.

Because tools/bpftool no longer exists,
also update bpftool executable to build/bpftool/bpftool.

Signed-off-by: Jacky Yin <[email protected]>
@JackyYin JackyYin force-pushed the cmake-build-bpftool branch from 4695db5 to d5b9c6e Compare May 25, 2022 04:43
@JackyYin
Copy link
Contributor Author

I see this follows the approach for building libbpf so looks sane to me. Please fix the typo and can you also add Signed-off-by: with your full name and email just like libbpf/kernel commits have it? Thanks!

Thanks for your feedback!
I just fixed the typo and added the Signed-off-by to my commit message.
The commit is squashed and force-pushed back again.

@anakryiko anakryiko merged commit b8b457c into libbpf:master May 25, 2022
@anakryiko
Copy link
Member

Thanks!

@danobi
Copy link
Member

danobi commented May 26, 2022

lgtm

@anakryiko anakryiko mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakryiko anakryiko anakryiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackyYin @anakryiko @danobi