add custom_api directory with create and update #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchand-Nicolas
requested changes
Sep 28, 2024
Comment on lines
54
to
59
| // Build a vector of FieldElement from the comma separated contracts string | ||
| let parsed_contracts: Vec<FieldElement> = body | ||
| .contracts | ||
| .split(",") | ||
| .map(|x| FieldElement::from_str(&x).unwrap()) | ||
| .collect(); |
There was a problem hiding this comment.
This part is unused
Marchand-Nicolas
requested changes
Sep 28, 2024
src/endpoints/mod.rs
Outdated
| @@ -17,3 +17,4 @@ pub mod leaderboard; | |||
| pub mod quest_boost; | |||
| pub mod quests; | |||
| pub mod unique_page_visit; | |||
| pub mod custom_api; | |||
There was a problem hiding this comment.
This is not the right mod. There i a mod.rs in each folder. This is to indicate rust all the dependency tree. Every time, when adding a folder or a file, we need to update the mod.rs that is in the same directory. In your case, you added your folder in src\endpoints\admin, so you have to update src\endpoints\admin\mod.rs
Comment on lines
+1
to
+2
| pub mod create_custom_api; | ||
| pub mod update_custom_api; |
There was a problem hiding this comment.
Here this mod.rs is setup perfectly
|
Also, I suggest you to try installing cargo so that you can try compiling or running the project, because all these issues are compiling issues, not even runtime issues |
|
Noted, sorry, an oversight from my own end, Thank you ser. |
Marchand-Nicolas
approved these changes
Sep 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completed the task by adding the
custom_apidirectory and setting up thePOSTandPUTmethod for it. Also, added theapi_urlandregexfields to theQuestTaskDocumentin themodels.rsfile. Also made changes to all the files using theQuestTaskDocumentto include theapi_urland theregexfields, setting their values as None, since they are not needed in those other context, at least in this scope. I also did this to remove likely errors that might emanate from those files due to the changes I made to theQuestTaskDocumentmodel in themodels.rsfile.