Skip to content
This repository was archived by the owner on Sep 22, 2024. It is now read-only.

Removal of failing federated template #62

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

edwardalee
Copy link
Contributor

This PR removes one of the template files which fails in testing. Nobody uses these template files anyway. They really aren't very useful, so the mysterious error is not worth the trouble of tracking down.

@edwardalee edwardalee requested a review from lhstrh March 16, 2024 12:03
@lhstrh
Copy link
Member

lhstrh commented Mar 17, 2024

needs to also be removed, or else someone could click on that option and get a runtime error.

@edwardalee
Copy link
Contributor Author

needs to also be removed, or else someone could click on that option and get a runtime error.

OK, I've removed it.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhstrh lhstrh self-requested a review March 18, 2024 15:48
@lhstrh
Copy link
Member

lhstrh commented Mar 18, 2024

Looks like there is a dangling reference to FederatedProject (compilation error).

@edwardalee
Copy link
Contributor Author

Looks like there is a dangling reference to FederatedProject (compilation error).

Just pushed a fix to that... Interestingly, I got no error running the tests locally.

@lhstrh lhstrh merged commit e2f5576 into main Mar 18, 2024
4 checks passed
@lhstrh lhstrh changed the title Removed failing federated template Removal of failing federated template Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants