This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not enough. We need to update travis config (and, of course, make tests passing). diff --git a/.travis.yml b/.travis.yml
index ce6a4ad..29dd8ff 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -9,6 +9,7 @@ php:
- 7.1
- 7.2
- 7.3
+ - 7.4snapshot
env:
global:
@@ -18,9 +19,11 @@ env:
matrix:
include:
- php: 5.6
- env: MONGO_EXTENSION="mongo.so" SYMFONY_VERSION="symfony/lts:^2"
- - php: 7.1
- env: SYMFONY_VERSION="symfony/lts:^3"
+ env: MONGO_EXTENSION="mongo.so" SYMFONY_VERSION="^2.8"
+ - php: 7.2
+ env: MONGO_EXTENSION="mongo.so" SYMFONY_VERSION="^3.4"
+ - php: 7.3
+ env: SYMFONY_VERSION="^4.4"
fast_finish: true
services:
@@ -33,7 +36,10 @@ before_install:
before_script:
- composer config platform.ext-mongo 1.6.16
- - if [ "$SYMFONY_VERSION" != "" ]; then travis_wait composer require --no-update $SYMFONY_VERSION; fi;
+ - |
+ if [ "$SYMFONY_VERSION" != "" ]; then
+ sed -ri 's/"symfony\/(.+)": "(.+)"/"symfony\/\1": "'$SYMFONY_VERSION'"/' composer.json;
+ fi;
- travis_wait composer update --prefer-dist --no-interaction $COMPOSER_FLAGS
- if ! [[ $TRAVIS_PHP_VERSION =~ ^5 ]]; then composer require alcaeus/mongo-php-adapter; fi;
diff --git a/Tests/TestCase.php b/Tests/TestCase.php
index 6482bf9..dd5eafc 100644
--- a/Tests/TestCase.php
+++ b/Tests/TestCase.php
@@ -140,6 +140,13 @@ abstract class TestCase extends \PHPUnit\Framework\TestCase
$loadXml = new XmlFileLoader($container, new FileLocator(__DIR__.'/../vendor/symfony/framework-bundle/Resources/config'));
$loadXml->load('services.xml');
+ $loadXml->load('web.xml');
+ $loadXml->load('error_renderer.xml');
+ #$loadXml->load('serializer.xml');
+ $loadXml->load('cache.xml');
+
+ $loadXml = new XmlFileLoader($container, new FileLocator(__DIR__.'/../vendor/doctrine/doctrine-bundle/Resources/config'));
+ $loadXml->load('dbal.xml');
$loadXml = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
$loadXml->load('services.xml');
diff --git a/composer.json b/composer.json
index 38868a7..fcbcf0c 100644
--- a/composer.json
+++ b/composer.json
@@ -24,6 +24,7 @@
"symfony/form": "~2.8|~3.0|^4.0"
},
"require-dev": {
+ "doctrine/doctrine-bundle": "^1.12|^2.0",
"doctrine/mongodb-odm-bundle": "^3.0",
"phpunit/phpunit": "~5.0|^7.5"
}, |
Can't use |
Need to require |
Hi @garak, Thx I will try your patch, but why php7.4? why not? :D I think the TestCase could be refactored 🤔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for installing on symfony 5 #SymfonyHackday