Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance decreased severely #331

Closed
TheOnlyWiseJEDI opened this issue Nov 6, 2023 · 11 comments
Closed

Performance decreased severely #331

TheOnlyWiseJEDI opened this issue Nov 6, 2023 · 11 comments
Assignees

Comments

@TheOnlyWiseJEDI
Copy link

Using: text-generastion-webui
Model: ehartford_dolphin-2.2-mistral-7b - not quantized
Installed: using pip install -r requirements
OS: Windows 10
Shell: cmd.exe
Python: Python 3.11.3
pymemgpt installed: yes
Hardware: 12th Gen i7 64GB/RAM, RTX3060 12GB RAM
LLM and MemGPT on same system

I have recently reinstalled memgpt so all is fresh and up to date. I have NOT altered any settings in text-generation-webui. This problem existed before and after a reinstall.

There is a significant performance decrease since a recent update. 'reporter' said he thought it might be the grammar update and that he noticed it also. What used to be a processing time of 4 - 12 seconds has become more often than not, 20+ seconds. Even as much as 39 seconds.

With the model loaded and memgpt running these results are consistent through the CLI however if I flip to the webui interface and pose the same question the performance time is more than 1/2 faster than when done through memgpt. This was not true last week (presumably prior to whatever update changed things).

@cpacker
Copy link
Collaborator

cpacker commented Nov 6, 2023

@TheOnlyWiseJEDI can you try disabling grammar by forcing a specific wrapper?

If you pass --model airoboros-l2-70b-2.1, it shouldn't use grammar, so things should be as they were before (unless there's something I'm missing).

(If you don't pass any model, the default will be grammar-based)

@TheOnlyWiseJEDI
Copy link
Author

TheOnlyWiseJEDI commented Nov 6, 2023 via email

@TheOnlyWiseJEDI
Copy link
Author

TheOnlyWiseJEDI commented Nov 6, 2023 via email

@TheOnlyWiseJEDI
Copy link
Author

it looked like the images didn't get included when I replied from email, not sure if you could see them, I edited and reapplied the images, they should be available now

@cpacker
Copy link
Collaborator

cpacker commented Nov 6, 2023

It is no longer possible to use --model when using memgpt with 'run' image image

@vivi @sarahwooders can we do a hotpatch on this?

@vivi
Copy link
Contributor

vivi commented Nov 6, 2023

@TheOnlyWiseJEDI For now you can run memgpt run --model airoboros-l2-70b-2.1 and hit 'N' when asked "Would you like to select an existing agent?"

Hmm -- just saw your comment that you tried to do that. Looking into this now.

@vivi
Copy link
Contributor

vivi commented Nov 6, 2023

@TheOnlyWiseJEDI I can't seem to reproduce your bug on 0.1.18a1. Could you run pip show pymemgpt and if the version is <0.1.18a1, run pip install pymemgpt -U --pre?

I do think that you should be able to reload the same agent with the same wrapper so I have opened #338.

@TheOnlyWiseJEDI
Copy link
Author

TheOnlyWiseJEDI commented Nov 7, 2023 via email

@sarahwooders
Copy link
Collaborator

If you run pip install pymemgpt -U --pre, you should be able to have the --model flag without an error, as long as it matches the model of the agent you are resuming. You don't need to specify any additional flags if you're resuming an existing agent.

@TheOnlyWiseJEDI
Copy link
Author

TheOnlyWiseJEDI commented Nov 7, 2023 via email

@cpacker
Copy link
Collaborator

cpacker commented Nov 7, 2023

Closing this particular issue because it should be resolved in the update that just went live (0.1.18), but @TheOnlyWiseJEDI feel free to reopen if it's still happening or open a new issue if something else is wrong.

@cpacker cpacker closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants